Partially working with IE

[liquiddc]

Hi These changes incorporate the eventsource polyfill from yaffle to make dashing almost work on IE. Creating a new dashing dashboard with this branch shows the chart part of the convergence widget working on IE (and nothing broken on other browsers). This proves the jobs send event data is being picked up by the eventsource in IE. But none of the batman bindings seem to work so the other widgets don't work. There are no errors logged to the js console in IE and it's not immediately obvious to me how to debug this problem in any more depth.

[bielfrontera]

Hi!
I think I've found why widgets are not loaded in IE. The problem is that object.constructor.name doesn't work in IE. This property is used at dashing.coffee:

class Dashing.Widget extends Batman.View
  constructor:  ->
    # Set the view path
    @constructor::source = Batman.Filters.underscore(@constructor.name)
    super

You can patch IE following this instructions: http://matt.scharley.me/2012/03/09/monkey-patch-name-ie.html (via stackoverflow )

[bielfrontera]

The patch I suggested before does not work when code is minified. I've finally added this method to Dashing.widget class:

  getName: () =>
    funcNameRegex = /function ([^\(]{1,})\(/;
    results = (funcNameRegex).exec(@constructor.toString())
    if (results && results.length > 1) then results[1].trim() else ""

And changed constructor.name by getName() at the class constructor method.

I've tested in Firefox, Chrome and Internet Explorer (10 and 11) and it works with javascript minified (attention, the code is not uglified).

[anweiss]

I'm noticing that even the Sample dashboard still does not work in IE11, despite this fix.

[bielfrontera]

I've tried on IE11 after applying @liquiddc changes and constructor.name replacement and it works:

[Floppy]

Verified this is working for me in IE11. I have a branch with both the @liquiddc and @bielfrontera changes in, and it's working just fine: https://github.com/theodi/dashing/tree/ie. Thanks guys!

[terraboops]

Either this or #322 should be merged. This PR seems to be more comprehensive and well-tested.

Will have to look at this in greater detail to decide which is better.

[ghost]

@tylermauthe any update? would be nice to have it merged.

[cjdcordeiro]

Hi,

many thanks for that fix.
One thing though, what about Microsoft Edge? I see this fix does not make it work with Edge...any suggestions?

[lunarose23]

Any news on this? if we decide to go with dashing I may be forking and doing this. But want to make sure before I spend time on it that someone already didn't and it has some sort of block.

[terraboops]

🚫

[christianhau]

Would love to get an update on this as I have a dashboard that I have to how in IE that currently doesn't work.. Thanks in advance!