Remove src/backend #3413

TueeNguyen · 2022-04-06T18:08:51Z

Issue This PR Addresses

Part of #2777

I'm removing the code here
Will change the docs after this PR

Type of Change

Bugfix: Change which fixes an issue
New Feature: Change which adds functionality
Documentation Update: Change which improves documentation
UI: Change which improves UI

Description

Remove most of backend code

Steps to test the PR

cp config/env.development .env
pnpm services:start parser studio db kong rest meta
pnpm db:init
I guess if pnpm services:start run normally that's fine
Need to keep in mind if other parts of telescope use anything from legacy backend
Need to merge and test on staging to know exactly what will happen

Checklist

Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

gitpod-io · 2022-04-06T18:08:58Z

TDDR · 2022-04-07T01:15:25Z

I did a gh pr checkout 3413 and then pnpm services:start and got this error

Did I do something wrong?

TueeNguyen · 2022-04-07T01:29:14Z

@TDDR Ah they timed out, can you try again?

TDDR

Tested out on local and all seems to be working. I'm not sure of the greater ramifications of removing all this code but it looks to be working.

package.json

docker/development.yml

JerryHue

I went through all files with Tue on a meeting, so I am sure that this can be approved now. We have to be aware, though, that we modified the CI workflows, so when we merge, we gotta be attentive to the build status.

humphd

Nice work. A few questions.

humphd · 2022-04-07T21:40:27Z

config/env.development

-# PORT is the port used by the web server
-PORT=3000
-
-# API_URL is the URL of the Telescope Web API server.  Change this to


The only thing we lose by doing this is the ability to work on the front-end locally, but use the staging server as your back-end. Probably that's OK, and we should migrate to using GitPod or EC2 cloud instances instead, so you can run everything at once.

config/env.development

docker/production.yml

package.json

src/web/app/src/config.ts

package.json

old

- Remove all tests from /test - Remove src/backend - Remove API_URL related code in front-end + other files - Remove 'telescope' container in production.yml - Remove backend dependencies from package.json - Change some in config files

vercel bot deployed to Preview April 6, 2022 18:08 View deployment

tcvan0707 assigned TueeNguyen Apr 6, 2022

vercel bot deployed to Preview April 6, 2022 20:21 View deployment

vercel bot deployed to Preview April 6, 2022 20:30 View deployment

TueeNguyen marked this pull request as ready for review April 6, 2022 20:37

vercel bot deployed to Preview April 6, 2022 20:40 View deployment

vercel bot deployed to Preview April 6, 2022 20:55 View deployment

TueeNguyen changed the title ~~Remove backend~~ Remove src/backend Apr 6, 2022

vercel bot deployed to Preview April 7, 2022 00:42 View deployment

TDDR requested review from TDDR and humphd April 7, 2022 01:16

TDDR previously approved these changes Apr 7, 2022

View reviewed changes

RC-Lee reviewed Apr 7, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

TueeNguyen dismissed TDDR’s stale review via e6551c8 April 7, 2022 12:36

vercel bot deployed to Preview April 7, 2022 12:36 View deployment

vercel bot deployed to Preview April 7, 2022 13:19 View deployment

TueeNguyen commented Apr 7, 2022

View reviewed changes

docker/development.yml Outdated Show resolved Hide resolved

vercel bot deployed to Preview April 7, 2022 16:26 View deployment

TueeNguyen force-pushed the move-backend-2 branch from 3833b79 to 1b1fddb Compare April 7, 2022 16:42

vercel bot deployed to Preview April 7, 2022 16:42 View deployment

TueeNguyen force-pushed the move-backend-2 branch from 1b1fddb to 9ba4e4e Compare April 7, 2022 17:13

vercel bot deployed to Preview April 7, 2022 17:14 View deployment

JerryHue previously approved these changes Apr 7, 2022

View reviewed changes

humphd requested changes Apr 7, 2022

View reviewed changes

menghif previously requested changes Apr 7, 2022

View reviewed changes

package.json Show resolved Hide resolved

TueeNguyen dismissed JerryHue’s stale review via dc66e43 April 8, 2022 01:03

vercel bot deployed to Preview April 8, 2022 01:03 View deployment

TueeNguyen force-pushed the move-backend-2 branch from a1efe01 to d64b420 Compare April 22, 2022 15:32

vercel bot deployed to Preview April 22, 2022 15:32 View deployment

tpmai22 dismissed stale reviews from joelazwar, JiaHua-Zou, and TDDR via d64b420 April 22, 2022 16:08

TueeNguyen force-pushed the move-backend-2 branch from d64b420 to 7ed856c Compare April 22, 2022 18:10

vercel bot deployed to Preview April 22, 2022 18:10 View deployment

TueeNguyen force-pushed the move-backend-2 branch from 7ed856c to 686f723 Compare April 22, 2022 18:39

vercel bot deployed to Preview April 22, 2022 18:39 View deployment

TueeNguyen force-pushed the move-backend-2 branch from 686f723 to f900e64 Compare April 22, 2022 19:08

vercel bot deployed to Preview April 22, 2022 19:08 View deployment

TueeNguyen force-pushed the move-backend-2 branch from f900e64 to aeb96f5 Compare April 22, 2022 19:30

vercel bot deployed to Preview April 22, 2022 19:30 View deployment

vercel bot deployed to Preview April 22, 2022 19:43 View deployment

DukeManh previously approved these changes Apr 22, 2022

View reviewed changes

JiaHua-Zou previously approved these changes Apr 22, 2022

View reviewed changes

TueeNguyen force-pushed the move-backend-2 branch from 4e57466 to 3f1a035 Compare April 22, 2022 20:00

vercel bot deployed to Preview April 22, 2022 20:00 View deployment

aserputov dismissed stale reviews from JiaHua-Zou and DukeManh via 3f1a035 April 22, 2022 20:06

JiaHua-Zou approved these changes Apr 22, 2022

View reviewed changes

sirinoks approved these changes Apr 22, 2022

View reviewed changes

TueeNguyen added 3 commits April 22, 2022 16:07

Remove backend:

5f01b14

- Remove all tests from /test - Remove src/backend - Remove API_URL related code in front-end + other files - Remove 'telescope' container in production.yml - Remove backend dependencies from package.json - Change some in config files

Update lock file

1c2e2d4

Update package.json + lock file

41523c8

TueeNguyen force-pushed the move-backend-2 branch from 3f1a035 to 41523c8 Compare April 22, 2022 20:07

vercel bot deployed to Preview April 22, 2022 20:08 View deployment

TueeNguyen merged commit 61dbefe into Seneca-CDOT:master Apr 22, 2022

joelazwar approved these changes Apr 22, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove src/backend #3413

Remove src/backend #3413

TueeNguyen commented Apr 6, 2022 •

edited by DukeManh

Loading

gitpod-io bot commented Apr 6, 2022

TDDR commented Apr 7, 2022

TueeNguyen commented Apr 7, 2022

TDDR left a comment

JerryHue left a comment

humphd left a comment

humphd Apr 7, 2022

Remove src/backend #3413

Remove src/backend #3413

Conversation

TueeNguyen commented Apr 6, 2022 • edited by DukeManh Loading

Issue This PR Addresses

Type of Change

Description

Steps to test the PR

Checklist

gitpod-io bot commented Apr 6, 2022

TDDR commented Apr 7, 2022

TueeNguyen commented Apr 7, 2022

TDDR left a comment

Choose a reason for hiding this comment

JerryHue left a comment

Choose a reason for hiding this comment

humphd left a comment

Choose a reason for hiding this comment

humphd Apr 7, 2022

Choose a reason for hiding this comment

TueeNguyen commented Apr 6, 2022 •

edited by DukeManh

Loading