Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Turborepo docs #2813

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Add Turborepo docs #2813

merged 1 commit into from
Feb 4, 2022

Conversation

menghif
Copy link
Contributor

@menghif menghif commented Feb 3, 2022

Issue This PR Addresses

Fixes #2737

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR adds initial documentation for Turborepo.

Steps to test the PR

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Feb 3, 2022

@aserputov aserputov added this to the 2.7 Release milestone Feb 3, 2022
@Kevan-Y Kevan-Y self-requested a review February 3, 2022 14:21
JerryHue
JerryHue requested changes Feb 3, 2022
View reviewed changes
docs/turborepo.md Outdated Show resolved Hide resolved
docs/turborepo.md Show resolved Hide resolved
docs/turborepo.md Outdated Show resolved Hide resolved
@Kevan-Y
Copy link
Contributor

Kevan-Y commented Feb 3, 2022

@JerryHue has some good points that need to fix. Besides that, it looks good.

@sirinoks sirinoks added the type: documentation (docs) Improvements or additions to documentation label Feb 3, 2022
HyperTHD
HyperTHD requested changes Feb 4, 2022
View reviewed changes
docs/turborepo.md Outdated Show resolved Hide resolved
docs/turborepo.md Outdated Show resolved Hide resolved
@menghif menghif requested review from JerryHue and HyperTHD February 4, 2022 01:00
humphd
humphd requested changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. A few minor typos

docs/turborepo.md Outdated Show resolved Hide resolved
docs/turborepo.md Outdated Show resolved Hide resolved
chrispinkney
chrispinkney previously approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@chrispinkney chrispinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool. Agree with the fixes above but otherwise LGTM! Nice work.

@aserputov aserputov self-requested a review February 4, 2022 01:38
@aserputov
Copy link
Contributor

@menghif rebase it and we can merge this one.

@menghif
Copy link
Contributor Author

menghif commented Feb 4, 2022

Rebased and ready to merge.

@menghif menghif merged commit 14b204d into Seneca-CDOT:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aserputov aserputov aserputov approved these changes

@JerryHue JerryHue JerryHue approved these changes

@Kevan-Y Kevan-Y Awaiting requested review from Kevan-Y

@HyperTHD HyperTHD Awaiting requested review from HyperTHD

@humphd humphd Awaiting requested review from humphd

@chrispinkney chrispinkney Awaiting requested review from chrispinkney

Assignees

@menghif menghif

Labels
type: documentation (docs) Improvements or additions to documentation
Projects
None yet
Milestone
2.7 Release
Development

Successfully merging this pull request may close these issues.

Documentation for Turborepo and how it works
8 participants
@menghif @Kevan-Y @aserputov @humphd @chrispinkney @HyperTHD @JerryHue @sirinoks