Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Textarea): fix broken ctrl-z on firefox #3343

Merged
merged 3 commits into from
Dec 24, 2018

Conversation

ericls
Copy link
Contributor

@ericls ericls commented Dec 18, 2018

In TextArea ctrl-z is currently broken on firefox if autoHeight is enabled.

I feel like it might be a firefox bug but this workaround will make it work.

@welcome
Copy link

welcome bot commented Dec 18, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

In TextArea ctrl-z is currently broken on firefox if autoHeight is enabled.

I feel like it might be a firefox bug but this workaround will make it work.
@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #3343 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3343      +/-   ##
==========================================
+ Coverage   99.89%   99.89%   +<.01%     
==========================================
  Files         170      170              
  Lines        2806     2807       +1     
==========================================
+ Hits         2803     2804       +1     
  Misses          3        3
Impacted Files Coverage Δ
src/addons/TextArea/TextArea.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93ad88...eb78c84. Read the comment docs.

@ericls ericls changed the title Fix broken ctrl-z in on firefox Fix broken ctrl-z on firefox Dec 19, 2018
@layershifter layershifter changed the title Fix broken ctrl-z on firefox fix(Textarea): fix broken ctrl-z on firefox Dec 24, 2018
@layershifter layershifter merged commit 23ff649 into Semantic-Org:master Dec 24, 2018
@welcome
Copy link

welcome bot commented Dec 24, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@layershifter
Copy link
Member

The issue is really strange 🤔
@ericls thanks for the fix!

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants