Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Sticky): add active prop #2053

Merged
merged 1 commit into from
Sep 18, 2017
Merged

feat(Sticky): add active prop #2053

merged 1 commit into from
Sep 18, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Sep 7, 2017

Ref: SO.

This PR:

  • add active prop to Sticky
  • refactors Sticky tests (use domEvent, described props, other cleanups)

@codecov-io
Copy link

codecov-io commented Sep 7, 2017

Codecov Report

Merging #2053 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
+ Coverage   99.76%   99.76%   +<.01%     
==========================================
  Files         148      148              
  Lines        2561     2573      +12     
==========================================
+ Hits         2555     2567      +12     
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Sticky/Sticky.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19e0056...3234a23. Read the comment docs.

@levithomason levithomason merged commit 8f88da7 into master Sep 18, 2017
@levithomason levithomason deleted the feat/sticky-active branch September 18, 2017 01:17
@levithomason
Copy link
Member

Awesome, changes LGTM.

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants