feat(Dropdown): implement selectOnNavigation prop

[rijk]

No description provided.

[levithomason]

Great, next steps here will be adding an example to the docs in /docs/app/Examples/modules/Dropdown/Usage. Be sure to add the example to the index.js in that directory as well.

Then, we also need a test for this in Dropdown-test.js. We should describe('selectOnKeydown') and add assertions for what it() does when true and false.

[codecov-io]

Codecov Report

Merging #2009 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2009      +/-   ##
=========================================
+ Coverage    99.8%   99.8%   +<.01%     
=========================================
  Files         148     148              
  Lines        2561    2590      +29     
=========================================
+ Hits         2556    2585      +29     
  Misses          5       5

Impacted Files	Coverage Δ
src/modules/Dropdown/Dropdown.js	100% <100%> (ø)	⬆️
src/modules/Modal/Modal.js	100% <0%> (ø)	⬆️
src/addons/Portal/Portal.js	100% <0%> (ø)	⬆️
src/modules/Sticky/Sticky.js	100% <0%> (ø)	⬆️
src/modules/Search/Search.js	100% <0%> (ø)	⬆️
src/elements/Step/Step.js	100% <0%> (ø)	⬆️
src/modules/Modal/ModalActions.js	100% <0%> (ø)	⬆️
src/behaviors/Visibility/Visibility.js	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60e2aa...0bf102b. Read the comment docs.

[levithomason]

Cool, thanks much! We'll get a review on this as soon as we can. I just made a release so we'll target next weekend for releasing this one.

[rijk]

Just to let you know: I was not able to test the Doc example.

[levithomason]

If you mean automated tests, that's OK. Doc example tests are a little looser than they should be right now. We just render them and assert no errors occurred. This is done automatically for you.

[rijk]

No, I meant I was unable to open the docs locally after building, to see if/how the example looked and worked. The tests should be passing.

[levithomason]

Fixed lint issues, testing manually. Hope to ship this one today as well!

[levithomason]

Ok, finished updating docs. I renamed this prop to selectOnNavigation since key down still applies for the Enter case.

I added test assertions and doc descriptions to clarify the prop controls the change in value. The fact that onChange is called is a side-effect of changing the value only.

[levithomason]

Released in [email protected]