chore(package): replace deprecated babel-plugin-__coverage__ #1940
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1940 +/- ##
=========================================
+ Coverage 99.77% 99.8% +0.03%
=========================================
Files 148 148
Lines 2640 2565 -75
=========================================
- Hits 2634 2560 -74
+ Misses 6 5 -1
Continue to review full report at Codecov.
|
karma.conf.js
Outdated
| @@ -46,6 +46,7 @@ module.exports = (karmaConfig) => { | |||
| singleRun: true, | |||
| preprocessors: { | |||
| // do not include 'coverage' preprocessor for karma-coverage | |||
| // TODO | |||
There was a problem hiding this comment.
I believe this will also be true for istanbul since the bundle is instrumented before it ever gets to Karma (the browser).
That said, an easy check would be to run tests and open coverage/lcov-report/index.html in browser an see if it looks right.
There was a problem hiding this comment.
Yep, I doubt that I left it. However, I will check
There was a problem hiding this comment.
If's a cruft TODO, coverage is collected normally without coverage preprocessor
layershifter
force-pushed
the
chore-coverage-plugin
branch
from
2d3258a to
8283608
Compare
|
Released in |
Rel #1895.
Details.