chore(es-modules): fix usage of require #1663
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/es-modules
branch
from
f55c871 to
f2f15ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #1663 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 141 141
Lines 2406 2406
=======================================
Hits 2400 2400
Misses 6 6Continue to review full report at Codecov.
|
|
Though this fixes the issue, it adds quite a bit of complexity for one module. We use the debugger mostly for development on the library itself, I don't think it is used my by others during development. What if we instead just strip these statements entirely from the built version? Perhaps a fork of babel-plugin-transform-remove-console would allow us to do this simply? Possibly also babel-plugin-remove-code could offer some tips. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1238.
Replaces #1237.
What it does?
Stipes our debug functionality to
debug.cjsanddebug.esfiles, who userequireandimportto fetchdebugmodule. Plugin forbabelreplaces import of module when build is for ES modules. This will fix our ES build for rollup and will left everything as is.@levithomason I will be glad to hear your opinion there.