Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): direct links, maximize, better props #1448

Merged
merged 7 commits into from
Mar 13, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Mar 13, 2017

Direct links to every example

You can now link to every example file, regardless of whether or not it has a title. Clicking the link icon gives the example the "focused" style shadow, scrolls it into view, and copies the link to your clipboard.

http://g.recordit.co/f441YlgsJK.gif

Maximize an example

You can now launch any example in a maximized window. This is super helpful for large examples, like Grids:

http://g.recordit.co/Ywx2w6GplV.gif

Edit Code

Toggling the code editor now scrolls the example into view and updates the url with the direct link:

http://g.recordit.co/NqYu4o2uYc.gif

@see Portal Components

I've added links to portal powered components.

image

Cleaner Callback Docs

I recently added return types to callback signatures. We also now support object property param definitions (needed in Tab PR #430). I've now cleaned up the callback signature layout as well:

image

@levithomason levithomason changed the title feat(docs): direct links, maximize, better props docs(examples): direct links, maximize, better props Mar 13, 2017
@codecov-io
Copy link

codecov-io commented Mar 13, 2017

Codecov Report

Merging #1448 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1448   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         141      141           
  Lines        2364     2364           
=======================================
  Hits         2358     2358           
  Misses          6        6
Impacted Files Coverage Δ
src/collections/Menu/Menu.js 100% <ø> (ø)
src/addons/Portal/Portal.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fb59f2...0ebf574. Read the comment docs.

@levithomason levithomason merged commit 1e06daa into master Mar 13, 2017
@levithomason levithomason deleted the docs/enhanced-examples branch March 13, 2017 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants