Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Dropdown): update typings and propTypes usage #1334

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Feb 15, 2017

This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.

@codecov-io
Copy link

codecov-io commented Feb 17, 2017

Codecov Report

Merging #1334 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files         140      140              
  Lines        2402     2401       -1     
==========================================
- Hits         2396     2395       -1     
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <ø> (ø)
src/modules/Dropdown/DropdownItem.js 100% <ø> (ø)
src/modules/Dropdown/DropdownHeader.js 100% <ø> (ø)
src/modules/Dropdown/DropdownMenu.js 100% <ø> (ø)
src/modules/Dropdown/DropdownDivider.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5a22e...dad515c. Read the comment docs.

@levithomason levithomason merged commit 5ee7b8a into master Feb 21, 2017
@levithomason levithomason deleted the style/dropdown branch February 21, 2017 00:11
@levithomason
Copy link
Member

Released in [email protected].

@wcatron
Copy link
Contributor

wcatron commented Feb 22, 2017

The typescripts in this PR are too strict.

Property 'onClick' DropdownItemProps
Select uses the DropDown props which require onClose, onFocus, onMouseDown, etc.

There are others. Should I open an issue addressing all of these or do you they need to be individual?

@levithomason
Copy link
Member

Please open a new issue or PR.

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants