Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Comment): add size prop to Group #1327

Merged
merged 9 commits into from
Feb 17, 2017
Merged

feat(Comment): add size prop to Group #1327

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c453840
fix(Comment.Group): added size prop
tarang9211 Feb 14, 2017
4c3391c
fix(Comment.Group): appending size prop value to className, added tests
tarang9211 Feb 14, 2017
f926aca
fix(Comment.Group): refactor to use SUI sizes
tarang9211 Feb 14, 2017
5eed6e4
fix(Comment.Group): fix typings
tarang9211 Feb 14, 2017
423754f
Update index.d.ts
layershifter Feb 14, 2017
796db52
Update CommentGroup-test.js
layershifter Feb 14, 2017
35fc2c4
Update CommentGroup.js
layershifter Feb 14, 2017
11023bd
Update index.d.ts
layershifter Feb 14, 2017
d323453
docs(Comment.Group): added comment group size examples to doc site
tarang9211 Feb 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/views/Comment/CommentGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ function CommentGroup(props) {
children,
collapsed,
minimal,
size,
threaded,
} = props

Expand All @@ -27,6 +28,7 @@ function CommentGroup(props) {
useKeyOnly(minimal, 'minimal'),
useKeyOnly(threaded, 'threaded'),
'comments',
size,
className,
)
const rest = getUnhandledProps(CommentGroup, props)
Expand Down Expand Up @@ -57,6 +59,9 @@ CommentGroup.propTypes = {
/** Comments can hide extra information unless a user shows intent to interact with a comment. */
minimal: PropTypes.bool,

/** Comments can have different sizes*/
size: PropTypes.oneOf(['mini', 'tiny', 'small', 'large', 'big', 'huge', 'massive']),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use SIZES const for definitions, example.


/** A comment list can be threaded to showing the relationship between conversations. */
threaded: PropTypes.bool,
}
Expand Down
3 changes: 3 additions & 0 deletions test/specs/views/Comment/CommentGroup-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,7 @@ describe('CommentGroup', () => {
common.propKeyOnlyToClassName(CommentGroup, 'collapsed')
common.propKeyOnlyToClassName(CommentGroup, 'minimal')
common.propKeyOnlyToClassName(CommentGroup, 'threaded')
common.propValueOnlyToClassName(CommentGroup, 'size', [
'mini', 'tiny', 'small', 'large', 'big', 'huge', 'massive',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

])
})