style(Feed): update typings and propTypes usage #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2017
Codecov Report@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
+ Coverage 95.91% 95.92% +<.01%
==========================================
Files 883 883
Lines 4926 4928 +2
==========================================
+ Hits 4725 4727 +2
Misses 201 201
Continue to review full report at Codecov.
|
levithomason
reviewed
Feb 5, 2017
|
|
||
| /** An event can contain additional information like a set of images. */ | ||
| images?: any; | ||
| images?: boolean | Array<any>; |
There was a problem hiding this comment.
Should this be array of React.ReactNode?
There was a problem hiding this comment.
We set React.ReactNode when we deal with contentShorthand, but in this case we have:
PropTypes.oneOfType([
PropTypes.bool,
customPropTypes.collectionShorthand,
]),Which represents array of itemShorthand, we mark it as any for now.
I want to add new TS types for customPropTypes in future.
levithomason
reviewed
Feb 5, 2017
|
Looks great, we'll follow up on types for customPropTypes in #1289 . |
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.