fix(Dropdown): fix arrow keys after no results #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
=========================================
Coverage ? 95.91%
=========================================
Files ? 883
Lines ? 4926
Branches ? 0
=========================================
Hits ? 4725
Misses ? 201
Partials ? 0
Continue to review full report at Codecov.
|
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1275
The Dropdown attempts to set the
selectedIndex(highlighted item) toundefinedafter encountering the "No results." message.This PR resets the
selectedIndexto0after every search change. This is inline with SUI core and was our original intention for this component.