Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Rating): update typings and propTypes usage #1253

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Conversation

layershifter
Copy link
Member

This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.

@codecov-io
Copy link

Codecov Report

Merging #1253 into master will increase coverage by -0.01%.

@@            Coverage Diff             @@
##           master    #1253      +/-   ##
==========================================
- Coverage    95.9%   95.89%   -0.01%     
==========================================
  Files         881      880       -1     
  Lines        4904     4900       -4     
==========================================
- Hits         4703     4699       -4     
  Misses        201      201
Impacted Files Coverage Δ
src/modules/Rating/RatingIcon.js 100% <ø> (ø)
src/modules/Rating/Rating.js 100% <ø> (ø)
src/collections/Grid/GridRow.js 100% <ø> (ø)
src/views/Statistic/StatisticValue.js 100% <ø> (ø)
src/views/Statistic/Statistic.js 100% <ø> (ø)
src/views/Statistic/StatisticGroup.js 100% <ø> (ø)
src/elements/Button/ButtonGroup.js 100% <ø> (ø)
src/views/Statistic/StatisticLabel.js 100% <ø> (ø)
src/collections/Grid/Grid.js 100% <ø> (ø)
src/collections/Grid/GridColumn.js 100% <ø> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5735515...bb65e00. Read the comment docs.

Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@levithomason levithomason merged commit d003911 into master Jan 31, 2017
@levithomason levithomason deleted the style/rating branch January 31, 2017 06:44
@levithomason
Copy link
Member

Released in [email protected].

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants