Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup position is not respected when near corner of window #1482

Closed
MindFreeze opened this issue Mar 20, 2017 · 0 comments · Fixed by #1483
Closed

Popup position is not respected when near corner of window #1482

MindFreeze opened this issue Mar 20, 2017 · 0 comments · Fixed by #1483

Comments

@MindFreeze
Copy link
Contributor

Steps

  1. Create a popup with a trigger at the top right corner of the window.
  2. Make it a large popup so it can't fit on any side of the trigger without going out of the window

Expected Result

It should be positioned according to the position prop.

Actual Result

It always defaults to the last value in the POSITIONS enum excluding the value from the position prop (mostly "bottom center"). And it never uses the user specified value from the prop.

Version

0.67.0

Testcase

Just look at https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/modules/Popup/Popup.js#L234

MindFreeze added a commit to MindFreeze/Semantic-UI-React that referenced this issue Mar 20, 2017
@MindFreeze MindFreeze changed the title Popup position is not respected when near edge of window Popup position is not respected when near corner of window Mar 20, 2017
MindFreeze pushed a commit to MindFreeze/Semantic-UI-React that referenced this issue Jul 25, 2017
MindFreeze pushed a commit to MindFreeze/Semantic-UI-React that referenced this issue Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant