fix(Progress): do not show progress without progress or label props

Semantic-Org · Feb 20, 2017 · b248a18 · b248a18
1 parent 691f51e
commit b248a18
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/modules/Progress/Progress.js b/src/modules/Progress/Progress.js
@@ -140,10 +140,9 @@ class Progress extends Component {
   }
 
   showProgress = () => {
-    const { label, precision, progress, total, value } = this.props
+    const { label, precision, progress } = this.props
 
-    if (label || progress || !_.isUndefined(precision)) return true
-    return !(_.every([total, value], _.isUndefined))
+    return label || progress || !_.isUndefined(precision)
   }
 
   render() {

diff --git a/test/specs/modules/Progress/Progress-test.js b/test/specs/modules/Progress/Progress-test.js
@@ -191,7 +191,7 @@ describe('Progress', () => {
 
   describe('total/value', () => {
     it('calculates the percent complete', () => {
-      shallow(<Progress value={1} total={2} />)
+      shallow(<Progress value={1} total={2} progress />)
         .children()
         .find('.progress')
         .should.contain.text('50%')