Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] Fixes cdp for Chrome and Firefox #9909

Merged
merged 6 commits into from
Oct 13, 2021
Merged

[js] Fixes cdp for Chrome and Firefox #9909

merged 6 commits into from
Oct 13, 2021

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Oct 13, 2021

Description

  • Fixes cdp for chrome and firefox
  • Added enableDebugger firefox option to enable debugger address which is used for CDP

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

if (debuggerAddress.match(/\/se\/cdp/)) {
if (debuggerAddress.match("ws:\/\/", "http:\/\/")) {
Copy link
Contributor

@pujagani pujagani Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These checks are not needed anymore. Just returning the debuggerAddress when it matches /se/cdp works fine with the Grid. Otherwise, the Grid complains about wrong protocol.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

Thank you @pujagani!

@AutomatedTester AutomatedTester merged commit 3782f97 into SeleniumHQ:trunk Oct 13, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
* replacing targets page and browser for ff and chrome

* Placing await

* Updating devtools_tests

* Removing extra checkes

Co-authored-by: David Burns <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants