[java] Fix getScreenshotAs: avoid unnecessary conversions #9308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alb-i986
force-pushed
the
getScreenshotAs-avoid-extra-conversions
branch
2 times, most recently
from
dc46b06 to
9cd4530
Compare
|
@alb-i986, could you please update your fork? Somehow I cannot do it myself through the GitHub UI |
alb-i986
force-pushed
the
getScreenshotAs-avoid-extra-conversions
branch
from
9cd4530 to
3a8a755
Compare
|
Kudos, SonarCloud Quality Gate passed! |
diemol
approved these changes
Mar 22, 2021
|
Thank you @diemol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that the getScreenshotAs methods were not leveraging
OutputType#convertFromPngBytes; instead, they were all usingOutputType#convertFromBase64Png, even when the raw bytes was what we got from the Server.Motivation and Context
Types of changes
Checklist