Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Add screenshot support for EventFiringWebElement #9258

Merged
merged 3 commits into from
Mar 18, 2021
Merged

[dotnet] Add screenshot support for EventFiringWebElement #9258

merged 3 commits into from
Mar 18, 2021

Conversation

TroyWalshProf
Copy link
Contributor

@TroyWalshProf TroyWalshProf commented Mar 11, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add support for taking element screenshot when the underlying web element is a EventFiringWebElement.

Motivation and Context

Fixes #9256

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2021

CLA assistant check
All committers have signed the CLA.

@TroyWalshProf TroyWalshProf changed the title Add screenshot support for EventFiringWebElement [dotnet] Add screenshot support for EventFiringWebElement Mar 11, 2021
@jimevans
Copy link
Member

@TroyWalshProf Have you signed the CLA? I'd like to merge this, but can't until that's done.

@TroyWalshProf
Copy link
Contributor Author

@jimevans - Forgot to run the recheck, CLA is signed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meging this as @jimevans said above.

@diemol diemol merged commit b0ff8df into SeleniumHQ:trunk Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't take web element screenshots when element were found using EventFiringWebDriver
4 participants