Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] Integrated NewSessionQueuer with the Router. #8856

Merged
merged 6 commits into from
Nov 10, 2020

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Nov 9, 2020

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Integrate NewSessionQueuer with the Router.

Motivation and Context

All new session requests will be routed via the NewSessionQueuer and added to the NewSessionQueue. Distributor will pick up the session requests and create the session.

The changes include:

  1. Make the Router aware of the NewSessionQueuer. Update the RouterServer.
  2. Update the Distributor by removing endpoint to create a new session. It should be routed via the NewSessionQueuer.
  3. Distributor tests are updated to use Either. Asserts are updated based on each test.
  4. Remove CreateSession class.
  5. Update the Distributor newsession() method to return Either.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani changed the title Session queuer router [grid] Integrated NewSessionQueuer with the Router. Nov 9, 2020
@pujagani pujagani force-pushed the session-queuer-router branch from 90f67c0 to fe7563d Compare November 9, 2020 12:04
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2020

CLA assistant check
All committers have signed the CLA.

@pujagani pujagani force-pushed the session-queuer-router branch from 9a81c16 to 6086c5e Compare November 10, 2020 14:52
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@diemol diemol merged commit 63f700d into SeleniumHQ:trunk Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants