Ruby - stop using an obsolete method of Net::HTTP #8408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masakazutakewaka
commented
Jun 9, 2020
| @@ -120,16 +120,16 @@ def latest | |||
| end | |||
| end | |||
|
|
|||
| def net_http | |||
| def net_http_start(address, &block) | |||
There was a problem hiding this comment.
Should I write about this in the CHANGE.log as this method is exposed to public?
There was a problem hiding this comment.
It might worth mentioning, but frankly, I don't think this was ever intended to be a public API.
p0deje
approved these changes
Jun 9, 2020
https://docs.ruby-lang.org/en/2.7.0/Net/HTTP.html#method-c-Proxy Net::HTTP::Proxy is an obsolete method, so replaced it with Net::HTTP.new as the doc above says
masakazutakewaka
force-pushed
the
rb-replace-obsolete-method
branch
from
f1a69e0 to
2ab56e1
Compare
|
Thank you! |
titusfortner
pushed a commit
to titusfortner/selenium
that referenced
this pull request
Aug 13, 2020
https://docs.ruby-lang.org/en/2.7.0/Net/HTTP.html#method-c-Proxy Net::HTTP::Proxy is an obsolete method, so replaced it with Net::HTTP.new as the doc above says
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Net::HTTP::Proxyis an obsolete method, so replaced it withNet::HTTP.newas the doc says -> https://docs.ruby-lang.org/en/2.7.0/Net/HTTP.html#method-c-ProxyMotivation and Context
To keep the code up to date.
Types of changes
Checklist