-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[javascript] Fix the syntax error preventing a test suite from running #8371
[javascript] Fix the syntax error preventing a test suite from running #8371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @seanpoulter !
Sorry for the force-push. I caught an old author/committer email address. 😓 |
Any idea how to fix the build error? Looks like it might be an |
Hi @seanpoulter , We need to build node:atoms before running the tests. Previously it was like
it was replaced recent with bazel
i think we need to also build atoms with bazel before running the tests. Regards, |
It's only one character breaking the TravisCI build. 🤦 See #8374. |
Thanks for updating the branch David. Now we only have 3 failures in the JavaScript build related to the relative locators. It isn't obvious to me how to fix those so I've created #8375 to discuss it (if you want help, otherwise feel free to close it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should merge this and iterate on the relative locators implementation in a separate PR and in the linked issue.
Thanks @seanpoulter!
Thanks Diego. Who should I talk to about the relative locators? 😀 |
Easiest is to come to the IRC/Slack workspace, ping us in the #selenium or @selenium-tlc channels. |
SeleniumHQ#8371) Co-authored-by: David Burns <[email protected]> Co-authored-by: Diego Molina <[email protected]>
Description
When I run the JavaScript tests from the HEAD of the master branch, a syntax error is reported saying the
describe
block does not support anasync function
. An example follows the PR template.Motivation and Context
As a developer who would like to contribute to the JavaScript library, I would like the JavaScript build and tests to pass so I can make changes with confidence
Types of changes
Checklist
bazel test //javascript/node/selenium-webdriver:tests
reports failuresProposed Changes
Actual Behaviour
Proposed Behaviour
Four fewer failures. 😉