Delete deprecated FindsBy* interfaces

[bongosway]

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Delete deprecated FindsBy* interfaces

Motivation and Context

Fixes #8175

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[bongosway]

TestUtilities.java is referencing HtmlUnit Driver, therefore cannot compile. Which in turn causes some tests to fail e.g. UsingPageFactoryTest.java
I have raised issue here SeleniumHQ/htmlunit-driver#89

Will it better to completely decouple htmlunit from TestUtilities.java given the fact they are not colocated and from my understanding not updated at the same pace?

[barancev]

Looks like an improved copy of my experimental branch killing_FindByXXX:
0dc3abc

The decision is not made yet if we're going to merge this branch. Yes, we're going to remove FindByXXX classes, but the implementation is not choosen yet.

[bongosway]

Looks like an improved copy of my experimental branch killing_FindByXXX:
0dc3abc

The decision is not made yet if we're going to merge this branch. Yes, we're going to remove FindByXXX classes, but the implementation is not choosen yet.

Yes. you are correct. it is an improved copy and I referenced it in the original ticket.
Sure no worries if decision is not reached yet or if you need to close this PR.

[shs96c]

I like that this leaves the original semantics in place, which is important. Thank you for picking this up!

[shs96c]

I suggest we merge this. It moves us forward, deletes the original interfaces, and appears to leave the original semantics in place.

[shs96c]

Thank you @bongosway!

[bongosway]

Thank you @bongosway!

👍
Thank you too for cleaning up. Truly appreciate your support.