Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response to RemoteWebDriver's client log level #7925

Conversation

vijay44
Copy link
Contributor

@vijay44 vijay44 commented Jan 10, 2020

Replaced log 'command' with 'response' in RemoteDriver.setLogLevel

Fixes #7632

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Replaced log 'command' with 'response' in RemoteDriver.setLogLevel


Fixes SeleniumHQ#7632
@shs96c
Copy link
Member

shs96c commented Feb 15, 2020

Ha! I can't believe we never noticed this before. Thank you for fixing it, and welcome to the project!

@shs96c shs96c merged commit d69ee97 into SeleniumHQ:master Feb 15, 2020
@vijay44
Copy link
Contributor Author

vijay44 commented Feb 15, 2020

Thanks @shs96c. It's my privilege and looking to contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the response to the logs when executing a RemoteWebDriver command in Java
2 participants