[js] Add windowTypes option support for ChromiumDriver #7897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Adds support for setting windowTypes option for ChromeDriver, which allows getting an extra set of window type handles like webview handles. For more info, see: https://chromedriver.chromium.org/capabilities
txava
force-pushed
the
support-windowTypes
branch
from
eaa342d to
1423547
Compare
txava
changed the title
|
Please add a test where you add a windowType and assert that the array contains that windowType. |
|
@txava, would you like to continue with this PR? Seems there are pending comments to resolve. |
harsha509
approved these changes
Apr 20, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
pujagani
pushed a commit
to pujagani/selenium
that referenced
this pull request
Apr 21, 2021
* [js] windowTypes option support for ChromiumDriver Adds support for setting windowTypes option for ChromeDriver, which allows getting an extra set of window type handles like webview handles. For more info, see: https://chromedriver.chromium.org/capabilities * [js] Add test for windowTypes option support for ChromiumDriver * [js] Replacing deepEqual(deprecated) with deepStrictEqual Co-authored-by: Sri Harsha <[email protected]> Co-authored-by: Sri Harsha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for setting windowTypes option for ChromeDriver, which
allows getting an extra set of window type handles like webview handles.
Motivation and Context
In order to be able to interact with a webview, one needs to get a handle for the webview (which is a window handle).
ChromeDriver won't return handles for webviews unless it is explicitly specified via windowTypes option see: https://chromedriver.chromium.org/capabilities.
Types of changes
Checklist