Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adding sonar sources for java,rb,py #7704

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

ddavison
Copy link
Member

No description provided.

@luke-hill
Copy link
Contributor

Hi @ddavison

I "think" this PR may be breaking the atoms composing. But I'm not 100%.

I've added a PR which builds off the latest master just with some extra logging. And (It's still building now). But Job #1 passes which fails here.

I've pinged barancev in slack. But I'll reference you there too if you need to chat. Unfortunately i'm on CET, so it's likely we may miss each other during a regular day.

I've done a bit of work refactoring that area recently, but the code in question was just moved, not refactored in any way. So I'm saying if there is an issue, it's likely a latent one (I can still try help fix it though)

@luke-hill
Copy link
Contributor

No idea if this will help, but this is 11 commits behind master? Maybe that would fix something 🤷‍♂️

@barancev barancev added the C-build Build related issues (bazel and CI) label Oct 31, 2019
@CLAassistant
Copy link

CLAassistant commented Nov 23, 2019

CLA assistant check
All committers have signed the CLA.

@AutomatedTester AutomatedTester merged commit cf51826 into master Jun 16, 2020
@diemol diemol deleted the sonar-sources branch June 17, 2020 11:46
barancev added a commit that referenced this pull request Jul 16, 2020
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
titusfortner pushed a commit to titusfortner/selenium that referenced this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-build Build related issues (bazel and CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants