Fix test to work with newer byte-buddy #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix test to work with newer byte-buddy Unblocks byte-buddy update from 1.8.3 to 1.8.12+. 1.8.12 (at least) requires the generated class has access to its super-interfaces, and will otherwise fail with messages like: java.lang.IllegalAccessError: class org.openqa.selenium.remote.RemoteWebDriver$ByteBuddy$CuMcRkYl cannot access its superinterface org.openqa.selenium.remote.BaseAugmenterTest$MagicNumberHolder
|
@joshbruning Have you signed CLA? |
|
Sorry, yeah, I have. I even have the commit bit - perhaps I should have used it. |
|
@joshbruning Yeah, I guess you could have just committed and pushed ;) |
|
@joshbruning, push it! |
grigaman
pushed a commit
to grigaman/selenium
that referenced
this pull request
Jul 12, 2018
Fix test to work with newer byte-buddy Unblocks byte-buddy update from 1.8.3 to 1.8.12+. 1.8.12 (at least) requires the generated class has access to its super-interfaces, and will otherwise fail with messages like: java.lang.IllegalAccessError: class org.openqa.selenium.remote.RemoteWebDriver$ByteBuddy$CuMcRkYl cannot access its superinterface org.openqa.selenium.remote.BaseAugmenterTest$MagicNumberHolder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test to work with newer byte-buddy
Unblocks byte-buddy update from 1.8.3 to 1.8.12+. 1.8.12 (at
least) requires the generated class has access to its super-interfaces,
and will otherwise fail with messages like:
java.lang.IllegalAccessError: class org.openqa.selenium.remote.RemoteWebDriver$ByteBuddy$CuMcRkYl
cannot access its superinterface org.openqa.selenium.remote.BaseAugmenterTest$MagicNumberHolder
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement