Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python syntax highlighting #5014

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Conversation

1kastner
Copy link
Contributor

@1kastner 1kastner commented Nov 4, 2017

Use .. code-block:: python instead of a plain ::

Use ``.. code-block:: python` instead of a plain `::`
@lmtierney
Copy link
Member

I just built the docs using this change and it looks the same as it currently does. Am I missing something?

@1kastner
Copy link
Contributor Author

1kastner commented Nov 4, 2017

@1kastner
Copy link
Contributor Author

1kastner commented Nov 4, 2017

As I only changed the docs, the failed builds are suspicious. At Travis I see it was a simple timeout and at AppVeyor the build crashes but so does the build of the master branch...

@lmtierney
Copy link
Member

Yeah you can ignore the Travis errors.

The files in the repo that you pointed to are used to build the docs which are then hosted here:

http://seleniumhq.github.io/selenium/docs/api/py/

@1kastner
Copy link
Contributor Author

1kastner commented Nov 4, 2017

@lmtierney If the docs even look beautiful in GitHub I think that is to be preferred, even though it is not a big improvement.

@lmtierney
Copy link
Member

Ok... I'll leave it up to @davehunt to decide

@davehunt
Copy link
Contributor

davehunt commented Nov 6, 2017

Looks good, thanks @1kastner

@davehunt davehunt merged commit d17e0ac into SeleniumHQ:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants