Add temporary iOS platform to aid W3C migration #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases we cannot consider platform and platformName to be equivalent. For example, SauceLabs uses platformName and not platform to run Appium tests. If we override platformName (iOS) with platform (Mac, because no iOS platform exists), we generate a set of invalid capabilities to actually run the browser test. Fixes #4557
Tom-Trumper
pushed a commit
to Tom-Trumper/selenium
that referenced
this pull request
Sep 11, 2017
In some cases we cannot consider platform and platformName to be equivalent. For example, SauceLabs uses platformName and not platform to run Appium tests. If we override platformName (iOS) with platform (Mac, because no iOS platform exists), we generate a set of invalid capabilities to actually run the browser test. Fixes SeleniumHQ#4557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we cannot consider platform and platformName to be
equivalent. For example, SauceLabs uses platformName and not
platform to run Appium tests. If we override platformName (iOS) with
platform (Mac, because no iOS platform exists), we generate a set of
invalid capabilities to actually run the browser test.
Fixes #4557
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement