Adding a LaunchApp command to Chrome specific webdriver client. #168

richardrb · 2014-02-19T17:59:21Z

Adding a LaunchApp command for the Chrome specific Java/Python webdriver clients, which is supported by chromedriver 2.9 and above. Many of our users use the client code here, and this will make it easier for Chrome app developers be able to test their apps using chromedriver.

AutomatedTester · 2014-02-27T16:43:07Z

From the Python side this looks ok but I wonder if the command file should be a third party dependency since this is specific to the way that Chrome works.

Your thoughts @jleyba ?

jleyba · 2014-02-27T17:56:22Z

java/client/src/org/openqa/selenium/chrome/ChromeCommandExecutor.java

@@ -38,18 +43,33 @@

  private final ChromeDriverService service;

+  private final static Map<String, CommandInfo> chromeCommandsNameToUrl = ImmutableMap.of(


Correct modifier order is static final

Use CHROME_COMMAND_NAME_TO_URL for the name as this is an immutable class constant.

Move this above the definition of the service field.

Done for the points above.

richardrb · 2014-03-03T18:48:00Z

@AutomatedTester I'd prefer to keep it there, it looks other browsers have specific implementations so it would be consistent with that (ie, firefox, opera, etc... directories). If you feel strongly about it I can put it over in third_party.

@jleyba Thanks for the review! I made changes based on your comments, please take another look when you have a chance.

lukeis · 2014-03-03T19:31:55Z

java/client/src/org/openqa/selenium/chrome/ChromeDriverCommand.java

@@ -0,0 +1,26 @@
+/*
+Copyright 2014 Selenium committers


the copyright should just be:
Copyright 2014 Software Freedom Conservancy

(remove the Selenium committers and Google reference)

Done. For here and the other files added.

lukeis · 2014-03-03T19:39:18Z

I don't necessarily agree with putting it in third party, almost makes more sense for chromedriver to release another python package to pypi for users to also grab, since this falls under the section of browser specific extensions to the protocol. @shs96c input appreciated.

richardrb · 2014-03-06T19:32:31Z

Hmm, I think it would be really helpful to end users to have this available in Selenium over having to download another package, in many cases users probably won't know this is available. There's already a hacky way to launch apps through the UI, so including this in Selenium will encourage users to do something better.

AutomatedTester · 2014-03-14T09:29:38Z

Sorry for not replying sooner.

I agree that yet another download is not useful. I suggest raising this on
the Selenium Developers mailing list. We at Mozilla have a similar
situation.

David

David Burns
Email: [email protected]
URL: http://www.theautomatedtester.co.uk/

On Thu, Mar 6, 2014 at 7:32 PM, richardrb [email protected] wrote:

Hmm, I think it would be really helpful to end users to have this
available in Selenium over having to download another package, in many
cases users probably won't know this is available. There's already a hacky
way to launch apps through the UI, so including this in Selenium will
encourage users to do something better.

Reply to this email directly or view it on GitHubhttps://github.com//pull/168#issuecomment-36926943
.

alanpca · 2014-05-22T16:17:10Z

@richardrb do you have any example specs which make use of this?

bayandin · 2014-10-20T16:23:40Z

Any updates? @AutomatedTester?
I want to add PerformanceLog feature and I want to do it the same way.

AutomatedTester · 2014-10-20T16:27:30Z

There is a discussion on https://groups.google.com/forum/m/#!topic/selenium-developers/-GS1wyTH2aI about this that has gone dead, I suggest posting there for an update

—
Sent from Mailbox

On Mon, Oct 20, 2014 at 5:23 PM, Alexander Bayandin
[email protected] wrote:

Any updates? @AutomatedTester?

I want to add PerformanceLog feature and I want to do it the same way.

Reply to this email directly or view it on GitHub:
#168 (comment)

andreastt · 2015-03-02T20:56:31Z

py/selenium/webdriver/remote/webdriver.py

@@ -62,7 +63,7 @@ def __init__(self, command_executor='http://127.0.0.1:4444/wd/hub',
            proxy.add_to_capabilities(desired_capabilities)
        self.command_executor = command_executor
        if type(self.command_executor) is bytes or type(self.command_executor) is str:
-            self.command_executor = RemoteConnection(command_executor, keep_alive=keep_alive)
+            self.command_executor = remote_connection_client(command_executor, keep_alive=keep_alive)


I can't see that the symbol remote_connection_client is defined here.

One of the commits in the PR added remote_connection_client parameter to this constructor. However that change is unnecessary and everything in this file needs to be reverted. (I'll add comments in chrome/webdriver.py explaining how)

andreastt · 2015-03-02T20:59:15Z

@richardrb, this change looks mostly good to me. Can you make the few changes requested and rebase? Sorry it's taken so long to get around to.

@AutomatedTester, I can't load the link you posted. If it's dead, should we close this?

AutomatedTester · 2015-03-15T21:17:38Z

As discussed in https://groups.google.com/forum/m/#!topic/selenium-developers/-GS1wyTH2aI we are going to close this and this will need to be released separately by the Chromium Project

p.s. I don't necessarily agree with this so suggest bringing it up in that email thread.

sevaseva · 2015-04-22T08:26:46Z

@shs96c @lukeis @andreastt @AutomatedTester

Some 20 days ago there was a post that suggested that how to implement vendor specific commands in the client bindings and where to put those client bindings' code are two separate questions. It didn't generate a lot of stir, fair enough.

If there is anyone who is actively against reopening and merging [1] this PR or against the proposal in the post (which is basically the same thing), can you please reply there or here?

While a decision about the place for vendor specific client code is being made in the other thread I see no reason to block changes in that code.

In fact, IEDriver and FirefoxDriver, ChromeDriver and possibly other vendor specific client side changes went in just fine recently. (phantomjs specific #475 almost made it in, too)

[1] After fixing issues including @andreastt suggestions and reverting unnecessary changes in core files webdriver/remote/webdriver.py and selenium/remote/HttpCommandExecutor.java.

sevaseva · 2015-04-24T10:20:36Z

Well, maybe there's no one who is actively again this anymore. Let's reopen, make last adjustments and merge this.

@richardrb , can you please

address @andreastt 's comment in py/selenium/webdriver/chrome/command.py
add a test in https://github.com/SeleniumHQ/selenium/tree/master/java/client/test/org/openqa/selenium/chrome that starts new session as new ChromeDriver() and verify that launchApp() method works as expected
similarly add a test in https://github.com/SeleniumHQ/selenium/tree/master/py/test/selenium/webdriver/chrome testing launch_app()
I will also add a couple comments inline that I would like to see addressed before we merge
we will need to squash commits before merging and of course rebase to the current HEAD

If any of these changes you don't know how or don't have time to do, let me know and I may do them; I'd make sure this change would still go in attributed to you even if I need to make adjustments before pushing.

sevaseva · 2015-04-24T10:29:11Z

py/selenium/webdriver/chrome/webdriver.py

@@ -61,6 +63,7 @@ def __init__(self, executable_path="chromedriver", port=0,
        try:
            RemoteWebDriver.__init__(self,
                command_executor=self.service.service_url,
+                remote_connection_client=ChromeRemoteConnection,


remote_connection_client parameter is unnecessary, it should not be passed here and reverted from remote/webdriver.py.

What you need to do is to pass an instance of ChromeRemoteConnection as a value of command_executor parameter.

See the current latest revision for an updated documentation that should make this less confusing:

selenium/py/selenium/webdriver/remote/webdriver.py

Line 64 in a19f07a

- command_executor - Either a string representing URL of the remote server or a custom

sevaseva · 2015-05-08T20:54:32Z

Lack of response from PR author.
After May 18 I should have a chance to address the comments and push a cleaned version of this.

@richardrb

/session/$sessionId/chromium/launch_app This is using the approach first proposed by @richardrb in pull request #168

@richardrb

/session/$sessionId/chromium/launch_app This is using the approach proposed by @richardrb in pull request #168

/session/$sessionId/chromium/launch_app This is related to pull request #168

richardrb added 8 commits February 18, 2014 17:33

Create command.py

d050592

Create remote_connection.py

bee8b2b

Update webdriver.py

36a9d76

Update webdriver.py

3744cad

Create ChromeDriverCommand.java

ce6a475

Update ChromeDriver.java

befdb2c

Update ChromeCommandExecutor.java

1337b45

Update HttpCommandExecutor.java

7ff729d

jleyba reviewed Feb 27, 2014
View reviewed changes

richardrb added 5 commits February 27, 2014 13:19

Update ChromeCommandExecutor.java

9f25326

Update ChromeDriverCommand.java

abc9890

Update ChromeCommandExecutor.java

91c18cc

Update ChromeCommandExecutor.java

493f166

Update ChromeDriverCommand.java

189c2d8

lukeis reviewed Mar 3, 2014
View reviewed changes

richardrb added 3 commits March 3, 2014 12:03

Updating Copyright Information

91da5d9

Updating Copyright Information

eea5568

Updating Copyright Information

d841066

AutomatedTester mentioned this pull request Apr 27, 2014

Add a new command to get HeapSnapshot for ChromeDriver. #131

Closed

selenium-ci force-pushed the master branch from 448e8f4 to 1571e66 Compare November 2, 2014 18:45

andreastt reviewed Mar 2, 2015
View reviewed changes

andreastt added R-needs code changes C-py R-needs rebase labels Mar 2, 2015

andreastt added the R-awaiting answer label Mar 2, 2015

AutomatedTester closed this Mar 15, 2015

sevaseva reopened this Apr 24, 2015

sevaseva reviewed Apr 24, 2015
View reviewed changes

sevaseva self-assigned this Aug 6, 2015

sevaseva added a commit that referenced this pull request Aug 6, 2015

Python client side support for launch_app command of chromedriver:

b0fbed0

/session/$sessionId/chromium/launch_app This is using the approach first proposed by @richardrb in pull request #168

sevaseva added a commit that referenced this pull request Aug 6, 2015

Java client side support for launch_app command of chromedriver:

1b6febd

/session/$sessionId/chromium/launch_app This is using the approach proposed by @richardrb in pull request #168

sevaseva added a commit that referenced this pull request Aug 6, 2015

JavaScript client side support for launch_app command of chromedriver:

395bd72

/session/$sessionId/chromium/launch_app This is related to pull request #168

sevaseva closed this Aug 6, 2015

sevaseva removed C-py R-awaiting answer R-needs code changes R-needs rebase labels Aug 6, 2015

snyk-bot mentioned this pull request Sep 16, 2021

[Snyk] Fix for 1 vulnerabilities XirdigH/selenium#12

Merged

jtnord mentioned this pull request Jul 26, 2023

[🐛 Bug]: remote selenium fails to respond to start new connections after some criteria #12421

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a LaunchApp command to Chrome specific webdriver client. #168

Adding a LaunchApp command to Chrome specific webdriver client. #168

richardrb commented Feb 19, 2014

AutomatedTester commented Feb 27, 2014

jleyba Feb 27, 2014

richardrb Feb 27, 2014

richardrb commented Mar 3, 2014

lukeis Mar 3, 2014

richardrb Mar 3, 2014

lukeis commented Mar 3, 2014

richardrb commented Mar 6, 2014

AutomatedTester commented Mar 14, 2014

alanpca commented May 22, 2014

bayandin commented Oct 20, 2014

AutomatedTester commented Oct 20, 2014

I want to add PerformanceLog feature and I want to do it the same way.

andreastt Mar 2, 2015

sevaseva Apr 24, 2015

andreastt commented Mar 2, 2015

AutomatedTester commented Mar 15, 2015

sevaseva commented Apr 22, 2015

sevaseva commented Apr 24, 2015

sevaseva Apr 24, 2015

sevaseva commented May 8, 2015

		@@ -38,18 +43,33 @@

		private final ChromeDriverService service;

		private final static Map<String, CommandInfo> chromeCommandsNameToUrl = ImmutableMap.of(

Adding a LaunchApp command to Chrome specific webdriver client. #168

Adding a LaunchApp command to Chrome specific webdriver client. #168

Conversation

richardrb commented Feb 19, 2014

AutomatedTester commented Feb 27, 2014

jleyba Feb 27, 2014

Choose a reason for hiding this comment

richardrb Feb 27, 2014

Choose a reason for hiding this comment

richardrb commented Mar 3, 2014

lukeis Mar 3, 2014

Choose a reason for hiding this comment

richardrb Mar 3, 2014

Choose a reason for hiding this comment

lukeis commented Mar 3, 2014

richardrb commented Mar 6, 2014

AutomatedTester commented Mar 14, 2014

alanpca commented May 22, 2014

bayandin commented Oct 20, 2014

AutomatedTester commented Oct 20, 2014

I want to add PerformanceLog feature and I want to do it the same way.

andreastt Mar 2, 2015

Choose a reason for hiding this comment

sevaseva Apr 24, 2015

Choose a reason for hiding this comment

andreastt commented Mar 2, 2015

AutomatedTester commented Mar 15, 2015

sevaseva commented Apr 22, 2015

sevaseva commented Apr 24, 2015

sevaseva Apr 24, 2015

Choose a reason for hiding this comment

sevaseva commented May 8, 2015