-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grid] rework the retry of http requests #14917 #14924
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit d3021cd)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
35b4af8
to
d3021cd
Compare
User description
Description
Remove the use of
dev.failsafe
inside theRetryRequest
with a simple loop.There is also a functional change,
Exception
s and error responses are delivered unmodified to the caller.This will allow the caller to handle the original
Exception
/ error response, so we do not loose data here.The old mapping did also not return a valid W3C response, so the client should not have been able to decode it.
Motivation and Context
see #14917
Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
dev.failsafe
library with a custom retry implementation using a simple loop mechanismdev.failsafe
libraryChanges walkthrough 📝
RetryRequest.java
Refactor HTTP request retry mechanism with custom implementation
java/src/org/openqa/selenium/remote/http/RetryRequest.java
dev.failsafe
library with a simple retry loop implementationresponses
errors
RetryRequestTest.java
Expand test coverage for RetryRequest implementation
java/test/org/openqa/selenium/remote/http/RetryRequestTest.java
BUILD.bazel
Remove failsafe dependency from build configuration
java/src/org/openqa/selenium/remote/http/BUILD.bazel
dev.failsafe
library