Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Enable SpotBugs for java_export #14882

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mk868
Copy link
Contributor

@mk868 mk868 commented Dec 9, 2024

User description

Description

As described in this comment, SpotBugs analysis was not enabled in all production classes.
The following PRs were created to fix the found problems:

This PR is the final one, enables a full analysis of SpotBugs.

Motivation and Context

  1. The SpotBugs analysis in all production classes is necessary to keep software quality high.
  2. This change is required by [java] NullAway checks added #14421

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

enhancement


Description

  • Enabled SpotBugs analysis by modifying the java_export function to use java_library from @contrib_rules_jvm//java:defs.bzl.
  • This change is part of a series of PRs aimed at improving software quality by enabling SpotBugs across all production classes.

Changes walkthrough 📝

Relevant files
Enhancement
export.bzl
Enable SpotBugs by modifying java_library usage                   

java/private/export.bzl

  • Added import for java_library from @contrib_rules_jvm//java:defs.bzl.
  • Replaced native.java_library with java_library in java_export
    function.
  • +2/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    qodo-merge-pro bot commented Dec 9, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Build Configuration
    Verify that replacing native.java_library with the contrib_rules_jvm version maintains all required functionality and doesn't introduce any breaking changes in the build process

    Copy link
    Contributor

    qodo-merge-pro bot commented Dec 9, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @VietND96 VietND96 merged commit f697509 into SeleniumHQ:trunk Dec 11, 2024
    9 of 10 checks passed
    @VietND96
    Copy link
    Member

    Thank you, @mk868!

    @mk868 mk868 deleted the enable-spotbugs branch December 11, 2024 07:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants