Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding information to package.json and gemspec files #14774

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

andrew
Copy link
Contributor

@andrew andrew commented Nov 18, 2024

User description

Description

Added funding_uri to both gemspecs and funding links to package.json to match with FUNDING.yml.

Motivation and Context

To help increase visibility using the bundle fund and npm fund commands.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

enhancement


Description

  • Added funding_uri to the selenium-devtools and selenium-webdriver gemspec files to enhance visibility for funding options.
  • Updated package.json to include a funding section with links to GitHub Sponsors and OpenCollective, supporting the npm fund command.

Changes walkthrough 📝

Relevant files
Enhancement
selenium-devtools.gemspec
Add funding URI to selenium-devtools gemspec                         

rb/selenium-devtools.gemspec

  • Added funding_uri to gemspec metadata.
  • Enhances visibility for funding options.
  • +2/-1     
    selenium-webdriver.gemspec
    Add funding URI to selenium-webdriver gemspec                       

    rb/selenium-webdriver.gemspec

  • Added funding_uri to gemspec metadata.
  • Enhances visibility for funding options.
  • +2/-1     
    package.json
    Add funding information to package.json                                   

    javascript/node/selenium-webdriver/package.json

  • Added funding section with GitHub and OpenCollective links.
  • Supports npm fund command for funding visibility.
  • +11/-1   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @CLAassistant
    Copy link

    CLAassistant commented Nov 18, 2024

    CLA assistant check
    All committers have signed the CLA.

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Validation Needed
    Verify that the GitHub sponsor URL is correct and active

    Configuration Check
    Verify that both funding URLs (GitHub and OpenCollective) are valid and point to the correct pages

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @VietND96 VietND96 requested a review from diemol November 19, 2024 10:37
    @VietND96 VietND96 merged commit b164d85 into SeleniumHQ:trunk Nov 19, 2024
    24 of 25 checks passed
    @VietND96
    Copy link
    Member

    Thank you, @andrew!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants