Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Add ChromiumNetworkConditions to command serialization #14716

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

pnatashap
Copy link
Contributor

@pnatashap pnatashap commented Nov 5, 2024

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

fix for #14712, add class to the context for json serialization

Motivation and Context

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix, Enhancement


Description


Changes walkthrough 📝

Relevant files
Enhancement
Command.cs
Add ChromiumNetworkConditions to JSON serialization           

dotnet/src/webdriver/Command.cs

  • Added ChromiumNetworkConditions to JSON serialization.
  • Ensures proper serialization of network conditions in Chromium.
  • +1/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @CLAassistant
    Copy link

    CLAassistant commented Nov 5, 2024

    CLA assistant check
    All committers have signed the CLA.

    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 5, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Potential Oversight
    The PR adds ChromiumNetworkConditions to JSON serialization, but it might be worth checking if there are any other related types that should also be added for consistency.

    Copy link
    Contributor

    qodo-merge-pro bot commented Nov 5, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Expand JSON serialization support for additional Chromium-specific types to ensure comprehensive serialization capabilities

    Consider adding other relevant Chromium-specific types to the JSON serialization
    attributes to ensure comprehensive serialization support for Chromium-related
    functionalities.

    dotnet/src/webdriver/Command.cs [160]

     [JsonSerializable(typeof(ChromiumNetworkConditions))]
    +[JsonSerializable(typeof(ChromiumOptions))]
    +[JsonSerializable(typeof(ChromiumPerformanceLoggingPreferences))]
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion proposes adding more Chromium-specific types for JSON serialization, which can improve the overall functionality and compatibility of the Chromium-related features. This enhancement aligns with the PR's focus on Chromium network conditions and can lead to more robust serialization support.

    7

    💡 Need additional feedback ? start a PR chat

    @nvborisenko
    Copy link
    Member

    @pnatashap please sign CLA.

    @nvborisenko nvborisenko changed the title add ChromiumNetworkConditions to serialization [dotnet] Add ChromiumNetworkConditions to command serialization Nov 5, 2024
    Copy link
    Member

    @nvborisenko nvborisenko left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @pnatashap !

    @nvborisenko nvborisenko merged commit f92d485 into SeleniumHQ:trunk Nov 5, 2024
    10 checks passed
    @pnatashap pnatashap deleted the 14712 branch November 6, 2024 01:43
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants