-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Remote connection use timeout from ClientConfig #14692
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Viet Nguyen Duc <[email protected]>
99f8865
to
806e384
Compare
CI Failure Feedback 🧐
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Should be merged after [py] DeprecationWarning raised in default webdriver init #14690
Fixes [🐛 Bug]: [Python] 4.26.0 request Read timed out. (read timeout=120) when init remote to Grid #14691
The idea in [py] Avoid waiting indefinitely on a frozen chromedriver process #14578 is still retained. Just moved default 120s to ClientConfig in the corresponding driver init.
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
ClientConfig
object with a default timeout of 120 seconds for various WebDriver remote connections (Chromium, Firefox, Safari, IE).ClientConfig
timeout in HTTP requests.Changes walkthrough 📝
remote_connection.py
Set default ClientConfig for Chromium remote connection
py/selenium/webdriver/chromium/remote_connection.py
ClientConfig
with a 120s timeout.remote_server_addr
andkeep_alive
parameters fromsuper()
call.remote_connection.py
Set default ClientConfig for Firefox remote connection
py/selenium/webdriver/firefox/remote_connection.py
ClientConfig
with a 120s timeout.remote_server_addr
andkeep_alive
parameters fromsuper()
call.webdriver.py
Implement ClientConfig in IE WebDriver initialization
py/selenium/webdriver/ie/webdriver.py
ClientConfig
for IE WebDriver.RemoteConnection
to useclient_config
.remote_connection.py
Set default ClientConfig for Safari remote connection
py/selenium/webdriver/safari/remote_connection.py
ClientConfig
with a 120s timeout.remote_server_addr
andkeep_alive
parameters fromsuper()
call.webdriver.py
Implement ClientConfig in Safari WebDriver initialization
py/selenium/webdriver/safari/webdriver.py
ClientConfig
for Safari WebDriver.SafariRemoteConnection
to useclient_config
.remote_connection.py
Use ClientConfig timeout in remote connection requests
py/selenium/webdriver/remote/remote_connection.py
_request
.timeout
fromClientConfig
.