Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Fixed typo in ResponseData MymeType -> MimeType #14670

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

BlitzDestroyer
Copy link
Contributor

@BlitzDestroyer BlitzDestroyer commented Oct 28, 2024

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixed typo in ResponseData record in dotnet/src/webdriver/BiDi/Modules/Network/ResponseData.cs

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix


Description

  • Fixed a typo in the ResponseData record within the C# codebase.
  • Changed the field name from MymeType to MimeType to correct the spelling.

PRDescriptionHeader.CHANGES_WALKTHROUGH

Relevant files
Bug fix
ResponseData.cs
Fix typo in ResponseData record field name                             

dotnet/src/webdriver/BiDi/Modules/Network/ResponseData.cs

  • Corrected a typo in the ResponseData record.
  • Changed MymeType to MimeType.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @CLAassistant
    Copy link

    CLAassistant commented Oct 28, 2024

    CLA assistant check
    All committers have signed the CLA.

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Typo Fix
    Verify that the typo correction from 'MymeType' to 'MimeType' is accurate and doesn't introduce any unintended changes in the code behavior.

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Update the TODO comment to suggest the correct unsigned integer type for HTTP status codes

    Consider updating the TODO comment to use the correct C# type 'uint' instead of
    'unit' for the Status property.

    dotnet/src/webdriver/BiDi/Modules/Network/ResponseData.cs [10]

    -int Status, // TODO: should be unit
    +uint Status, // TODO: consider changing to uint
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies a typo in the TODO comment and proposes using 'uint' instead of 'unit', which is relevant for HTTP status codes that are non-negative. This enhances code clarity and correctness.

    9

    💡 Need additional feedback ? start a PR chat

    @VietND96 VietND96 requested a review from nvborisenko October 28, 2024 23:41
    @VietND96 VietND96 changed the title Fixed typo in ResponseData MymeType -> MimeType [dotnet] Fixed typo in ResponseData MymeType -> MimeType Oct 29, 2024
    Copy link
    Member

    @nvborisenko nvborisenko left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Good catch, thanks!

    @nvborisenko nvborisenko merged commit 9b8cfb1 into SeleniumHQ:trunk Oct 29, 2024
    10 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants