-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Reduce RBS errors to 0 #14661
[rb] Reduce RBS errors to 0 #14661
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@p0deje I downgraded again the steep version to run in JRuby and merged the latest |
@p0deje fixed the linter issues and corrected steep so it doesn't generated a rubocop smell |
User description
Description
This PRs implements inline ignore comments for issues related to the steep checker and updates the types that were causing errors
Motivation and Context
To add full RBS support for Selenium and eventually allow us to add an RBS check on the pipeline.
The reference feature is #10943
The goal is also to be able to have no steep errors to start adding the right type on the classes that have untyped to have the right type enforces
Types of changes
Checklist
PR Type
Enhancement
Description
Changes walkthrough 📝
20 files
log_handler.rb
Add steep ignore comments for log handler method
rb/lib/selenium/webdriver/bidi/log_handler.rb
add_message_handler
method.account.rb
Add steep ignore comments for account initialization
rb/lib/selenium/webdriver/common/fedcm/account.rb
initialize
method.target_locator.rb
Add steep ignore comments for new window method
rb/lib/selenium/webdriver/common/target_locator.rb
new_window
method.common.rb
Add steep ignore comments for HTTP call method
rb/lib/selenium/webdriver/remote/http/common.rb
call
method.bidi.rbs
Update add_callback method signature in BiDi
rb/sig/lib/selenium/webdriver/bidi.rbs
add_callback
method signature to include event parameter.log_handler.rbs
Update log handler method signatures
rb/sig/lib/selenium/webdriver/bidi/log_handler.rbs
add_message_handler
block parameter optional.remove_message_handler
.struct.rbs
Specify untyped arguments for Struct class
rb/sig/lib/selenium/webdriver/bidi/struct.rbs
Struct
class to use untyped arguments.driver_finder.rbs
Add to_args method to driver finder
rb/sig/lib/selenium/webdriver/common/driver_finder.rbs
to_args
method definition.error.rbs
Allow optional keys in URLS hash
rb/sig/lib/selenium/webdriver/common/error.rbs
URLS
hash to allow optional keys.logger.rbs
Make block parameters optional in logger methods
rb/sig/lib/selenium/webdriver/common/logger.rbs
deprecate
anddiscard_or_log
methods.
options.rbs
Use untyped keys and values for options hash
rb/sig/lib/selenium/webdriver/common/options.rbs
@options
hash to use untyped keys and values.selenium_manager.rbs
Update binary_paths method to accept variable arguments
rb/sig/lib/selenium/webdriver/common/selenium_manager.rbs
binary_paths
method to accept variable string arguments.service.rbs
Add DRIVER_PATH_ENV_KEY constant
rb/sig/lib/selenium/webdriver/common/service.rbs
DRIVER_PATH_ENV_KEY
constant.websocket_connection.rbs
Update add_callback method with block parameter
rb/sig/lib/selenium/webdriver/common/websocket_connection.rbs
add_callback
method to include block parameter.account.rbs
Change initialize method to accept string arguments
rb/sig/lib/selenium/webdriver/fedcm/account.rbs
initialize
method to accept string arguments.options.rbs
Update options hash and enable_android parameters
rb/sig/lib/selenium/webdriver/firefox/options.rbs
@options
hash to use untyped keys and values.enable_android
method parameters.bidi_bridge.rbs
Update close method return type
rb/sig/lib/selenium/webdriver/remote/bidi_bridge.rbs
close
method return type to untyped.bridge.rbs
Update method signatures in remote bridge
rb/sig/lib/selenium/webdriver/remote/bridge.rbs
fedcm_account_list
method return type.select_fedcm_account
method to accept an index parameter.execute
method return type to string.response.rbs
Change code attribute type to integer
rb/sig/lib/selenium/webdriver/remote/response.rbs
@code
attribute type to integer.script.rbs
Update script initialization and handler methods
rb/sig/selenium/web_driver/script.rbs
initialize
method to useRemote::BiDiBridge
.1 files
struct.rb
Update comment for clarity in BiDi module
rb/lib/selenium/webdriver/bidi/struct.rb