Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py]: set consistent polling across java and python for WebDriverWait methods #14626

Merged
merged 2 commits into from
Oct 28, 2024
Merged

[py]: set consistent polling across java and python for WebDriverWait methods #14626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6487c96
move `time.sleep()` afterwards
navin772 Oct 20, 2024
1a74804
Merge branch 'trunk' into set_poll_frequency
harsha509 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions py/selenium/webdriver/support/wait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ def until(self, method: Callable[[D], Union[Literal[False], T]], message: str =
except self._ignored_exceptions as exc:
screen = getattr(exc, "screen", None)
stacktrace = getattr(exc, "stacktrace", None)
time.sleep(self._poll)
if time.monotonic() > end_time:
break
time.sleep(self._poll)
raise TimeoutException(message, screen, stacktrace)

def until_not(self, method: Callable[[D], T], message: str = "") -> Union[T, Literal[True]]:
Expand All @@ -122,7 +122,7 @@ def until_not(self, method: Callable[[D], T], message: str = "") -> Union[T, Lit
return value
except self._ignored_exceptions:
return True
time.sleep(self._poll)
if time.monotonic() > end_time:
break
time.sleep(self._poll)
raise TimeoutException(message)
Loading