Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Allow setting of PageDimensions and PageMargins in PrintOptions directly #14593

Merged
merged 15 commits into from
Oct 16, 2024
Merged

[dotnet] Allow setting of PageDimensions and PageMargins in PrintOptions directly #14593

Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1aee887
Added Missing Setters to C# PrintOptions Class
shbenzer Oct 13, 2024
b7d44c7
Merge branch 'trunk' into missing_setters_in_cs_printoptions
shbenzer Oct 13, 2024
9660fd2
Merge branch 'trunk' into missing_setters_in_cs_printoptions
shbenzer Oct 14, 2024
d3e9f1d
updated inline xml documentation
shbenzer Oct 14, 2024
c8be92b
Merge branch 'trunk' into missing_setters_in_cs_printoptions
shbenzer Oct 15, 2024
2a14dca
added handling for nulls in ToDictionary()
shbenzer Oct 15, 2024
7e21b68
optimized to avoid allocation)
shbenzer Oct 15, 2024
0372a8d
Added PrintOptions tests
shbenzer Oct 15, 2024
9999f72
converted, and slightly enhanced JUnit tests, to NUnit
shbenzer Oct 16, 2024
0e75a52
Rework one test
nvborisenko Oct 16, 2024
79f90bf
Will not rework after AI
nvborisenko Oct 16, 2024
c778b0d
Merge branch 'trunk' into missing_setters_in_cs_printoptions
shbenzer Oct 16, 2024
b84d54b
Removed ability to set PAgeSize or PageMargins as null... added tests…
shbenzer Oct 16, 2024
19a7c21
Fix it and forget
nvborisenko Oct 16, 2024
aeaeb13
Merge branch 'trunk' into missing_setters_in_cs_printoptions
nvborisenko Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dotnet/src/webdriver/PrintOptions.cs
View file
Open in desktop
shbenzer marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ public bool ShrinkToFit
public PageSize PageDimensions
{
get { return pageSize; }
set { pageSize = value; }
shbenzer marked this conversation as resolved.
Show resolved Hide resolved
}

/// <summary>
Expand All @@ -114,6 +115,7 @@ public PageSize PageDimensions
public Margins PageMargins
{
get { return margins; }
set { margins = value; }
}

/// <summary>
Expand Down