Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] remove un-needed print #14562

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

Delta456
Copy link
Contributor

@Delta456 Delta456 commented Oct 4, 2024

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Remove un-needed print(json) from bidi scripts

Motivation and Context

Fixes #14561

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix


Description


Changes walkthrough 📝

Relevant files
Bug fix
script.py
Remove unnecessary print statement in from_json method     

py/selenium/webdriver/common/bidi/script.py

  • Removed an unnecessary print statement from the from_json method.
  • +0/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    qodo-merge-pro bot commented Oct 4, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Cleanup
    Removal of unnecessary print statement improves code cleanliness and prevents unintended console output.

    Copy link
    Contributor

    qodo-merge-pro bot commented Oct 4, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @AutomatedTester AutomatedTester merged commit a67a2df into SeleniumHQ:trunk Oct 4, 2024
    1 check passed
    @Delta456 Delta456 deleted the remove_print branch November 6, 2024 10:30
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    [🐛 Bug]: unconditionally print console log entry when subscribed to event
    2 participants