Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Don't write trace log message when waiting until driver service is initialized #14557

Merged
merged 2 commits into from
Oct 3, 2024
Merged

[dotnet] Don't write trace log message when waiting until driver service is initialized #14557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a21bedc
[dotnet] Don't write trace log message when waiting until driver serv…
nvborisenko Oct 3, 2024
6565b60
Typo
nvborisenko Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions dotnet/src/webdriver/DriverService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
// limitations under the License.
// </copyright>

using OpenQA.Selenium.Internal.Logging;
using OpenQA.Selenium.Remote;
using System;
using System.Diagnostics;
Expand All @@ -42,7 +41,6 @@ public abstract class DriverService : ICommandServer
private bool isDisposed;
private Process driverServiceProcess;
private TimeSpan initializationTimeout = TimeSpan.FromSeconds(20);
private readonly static ILogger logger = Log.GetLogger<DriverService>();

/// <summary>
/// Initializes a new instance of the <see cref="DriverService"/> class.
Expand Down Expand Up @@ -238,10 +236,7 @@ protected virtual bool IsInitialized
}
catch (Exception ex) when (ex is HttpRequestException || ex is TaskCanceledException)
{
if (logger.IsEnabled(LogEventLevel.Trace))
{
logger.Trace(ex.ToString());
}
// do nothing: the exception is expected, meaning driver service is not initialized
}

return isInitialized;
Expand Down
Loading