[java]: fix decoding of line endings #14539
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #13207
Motivation and Context
It removes old code which changed the line endings from
\r\n
to\n
because it is not needed anymore and also breaks encoding-decoding. @titusfortner said removing this shouldn't impact anything and this code is also useless because other bindings don't do it.Types of changes
Checklist
PR Type
Bug fix
Description
\r\n
to\n
in theAbstractHttpResponseCodec
class, as it was unnecessary and caused encoding-decoding issues.Changes walkthrough 📝
AbstractHttpResponseCodec.java
Remove unnecessary line ending normalization in response decoding
java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java
\r\n
to\n
.