-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tox formatting for python files in format.sh
#14497
Conversation
PR Reviewer Guide 🔍(Review updated until commit 7d08453)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 7d08453
Previous suggestionsSuggestions up to commit d1215ea
|
This seems to not work on the CI. Can you look into it? |
I will take a look, from the CI logs it seems like selenium py package failed to build. For now, I will convert this to draft. |
Persistent review updated to latest commit 7d08453 |
@AutomatedTester I have updated the PR, can you please trigger the CI? |
The RBE test failures are unrelated to the changes. |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
It would be contributor friendly if we can have python formatting in
./scripts/format.sh
.Currently due to lack of formatting support from
rules_python
, bazel targets were not configurable (Added it as a TODO)Types of changes
Checklist
PR Type
enhancement, configuration changes
Description
format.sh
script usingtox
.tox
and configured it to use thelinting
environment.isort
,black
,flake8
, anddocformatter
.Changes walkthrough 📝
format.sh
Add Python formatting using tox in format.sh script
scripts/format.sh
tox
and setTOXENV
tolinting
.tox
with configuration frompy/tox.ini
.