Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml: warn about upcoming change enforcing string to have quotes #14491

Merged
merged 4 commits into from
Sep 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/src/org/openqa/selenium/grid/config/TomlConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,20 @@
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.logging.Logger;
import org.openqa.selenium.internal.Require;

public class TomlConfig implements Config {

private final Toml toml;
private static final Logger LOG = Logger.getLogger(TomlConfig.class.getName());

public TomlConfig(Reader reader) {
try {
toml = JToml.parse(reader);
LOG.warning(
"Please use quotes to denote strings. Upcoming TOML parser will require this and unquoted"
+ " strings will throw an error in the future");
} catch (IOException e) {
throw new ConfigException("Unable to read TOML.", e);
} catch (ParseException e) {
Expand Down
Loading