-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix type errors for input_device
and file_detector
#14459
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #14459 +/- ##
==========================================
+ Coverage 57.65% 57.68% +0.02%
==========================================
Files 89 89
Lines 5571 5579 +8
Branches 236 240 +4
==========================================
+ Hits 3212 3218 +6
+ Misses 2123 2121 -2
- Partials 236 240 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Delta456 !
Congratulations on your first contribution to Selenium @Delta456 🎉 🎉 🎉 ! |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR for type errors for
input_device.py
andfile_detector.py
as seen in https://github.com/SeleniumHQ/selenium/actions/runs/10626264126/job/29457778562