-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Merge android specific parameters in chrome options #14217
[java] Merge android specific parameters in chrome options #14217
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
@iampopovich seems the tests cannot be built https://github.com/SeleniumHQ/selenium/actions/runs/9745320822/job/26892961031?pr=14217#step:15:725 |
@diemol my bad , i forgot to import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run the build before?
Still getting errors: https://github.com/SeleniumHQ/selenium/actions/runs/9913402348/job/27390332113?pr=14217#step:15:482
@diemol i guess something happened with my working environment, and I missed another import. I also did not check the build in Gitpod. Now i ran build with command
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @iampopovich!
…Q#14217) * added androidOptions in merge method * applied suggestions * applying format.sh * import assertEquals * fix for importi Optional --------- Co-authored-by: Diego Molina <[email protected]>
…Q#14217) * added androidOptions in merge method * applied suggestions * applying format.sh * import assertEquals * fix for importi Optional --------- Co-authored-by: Diego Molina <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
according to bug #14133 I added androidOptions to merge method ChromiumOptions.mergeInPlace
I also added a test for the new functionality.
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
androidOptions
inChromiumOptions.mergeInPlace
method to handle Android-specific parameters.ChromeOptionsTest
to verify the correct merging of Android-specific options.Changes walkthrough 📝
ChromiumOptions.java
Add merging of Android-specific options in ChromiumOptions
java/src/org/openqa/selenium/chromium/ChromiumOptions.java
androidOptions
inmergeInPlace
method.androidOptions
before merging.ChromeOptionsTest.java
Add test for merging Android-specific options in ChromeOptions
java/test/org/openqa/selenium/chrome/ChromeOptionsTest.java