Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Add backtrace locations and cause to errors #14170
[rb] Add backtrace locations and cause to errors #14170
Changes from 37 commits
3ff3559
eb6aa00
ec6f5bc
6540f73
777a8a6
6883b0a
6a76481
0447c6d
4aae5a3
7e4a2cf
3c7b386
c4e2593
de16eec
4afe312
33bd311
48cb412
10791b2
5139bbf
d798475
2996653
05cfce6
ada5081
7529157
3c64035
5c9808a
176286c
48a7105
ef832d5
1f1dcae
c36c565
7497293
2f8b9f7
a506504
c7bc5d2
32536f5
eb0248e
9ff8252
ea9f4b4
ac8e22a
bfedee9
834a678
0ef5372
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably the only line that should have been changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed during testing that when setting the backtrace to the exception a couple of things happened:
The cause was not set which was the issue
Depending on the type of ex.backtrace this ended up in a type error
As the example in the previous conversation and the testing done with the selenium grid, it did not seem to have the effect we expected in the formatting of the backtrace, I added examples and my reasoning here: [rb] Add backtrace locations and cause to errors #14170 (comment)
Let me know if this doesn't make much sense to you and I will gladly make a PR to update this :) thank you so much for the help!