-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] Enable Firefox nightly for linux on arm64 #14099
Conversation
PR Review 🔍
|
PR Code Suggestions ✨
|
Looks like this is related to #13793
|
I compile it myself on for arm64. Generally it runs.
That is already the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I do not think that the failing test (Windows-only: fatal error LNK1181: cannot open input file 'windows.0.52.0.lib') is related to this change as this codepath is not relevant on Windows. |
No, that error is not related. In theory, that should be fixed in the trunk branch. |
Co-authored-by: Boni García <[email protected]>
Description
Mozilla provides nightly Firefox releases for ARM64 Linux now. Make selenium-manager aware of them.
Motivation and Context
On ARM64 Linux, selenium-manager downloads binaries for x86_64 even though there are releases for ARM64.
Types of changes
Checklist
PR Type
Enhancement
Description
Changes walkthrough 📝
firefox.rs
Add ARM64 support for nightly Firefox on Linux
rust/src/firefox.rs