-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Align binary location property for FirefoxOptions with other options #13901
[dotnet] Align binary location property for FirefoxOptions with other options #13901
Conversation
PR Description updated to latest commit (cd95b83)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
User description
Description
This is continuation of https://github.com/SeleniumHQ/selenium/issues/13885.
Motivation and Context
FirefoxOptions
class contains two properties with no difference. It is confusing.Probably we can just deprecate one of them to be aligned with other optionos? (chromium, safari)
Types of changes
Checklist
Type
enhancement
Description
browserBinaryLocation
tobinaryLocation
inFirefoxOptions
to standardize property naming across different browser options.BrowserExecutableLocation
and redirected its usage toBinaryLocation
, marking the former for future removal.Changes walkthrough
FirefoxOptions.cs
Align FirefoxOptions Binary Location Property Naming
dotnet/src/webdriver/Firefox/FirefoxOptions.cs
browserBinaryLocation
tobinaryLocation
to align with otherbrowser options.
BrowserExecutableLocation
property and redirected itsgetter and setter to
BinaryLocation
.DriverFactory.cs
Update Driver Factory to Use New Binary Location Property
dotnet/test/common/Environment/DriverFactory.cs
BrowserExecutableLocation
toBinaryLocation
inthe driver factory setup.