-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bidi][java] Enable grid BiDi chrome test #13778
Conversation
PR Description updated to latest commit (44f636d)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13778 +/- ##
=======================================
Coverage 58.63% 58.63%
=======================================
Files 86 86
Lines 5272 5272
Branches 218 218
=======================================
Hits 3091 3091
Misses 1963 1963
Partials 218 218 ☔ View full report in Codecov by Sentry. |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Enable grid BiDi Chrome test to ensure Augmenter works as expected and Grid supports BiDi.
Motivation and Context
Types of changes
Checklist
Type
enhancement, tests
Description
ChromeDriverInfo
.RemoteWebDriverBiDiTest
and enabled tests for detected browsers, excluding IE, Safari, and Edge.Changes walkthrough
2 files
ChromeDriverInfo.java
Enable BiDi Support in ChromeDriverInfo
java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java
true
inisSupportingBiDi
method.RemoteWebDriverBiDiTest.java
Enhance RemoteWebDriverBiDiTest with Setup and Browser Detection
java/test/org/openqa/selenium/grid/router/RemoteWebDriverBiDiTest.java
ignoring IE, Safari, and Edge.
10 files
BrowsingContextInspectorTest.java
Enable Browsing Context Inspector Tests for Chrome
java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java
@NotYetImplemented(CHROME)
annotations to enable tests forChrome.
BrowsingContextTest.java
Enable Browsing Context Tests for Chrome
java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextTest.java
@NotYetImplemented(CHROME)
annotations.CombinedInputActionsTest.java
Mark Combined Input Actions Test as Not Yet Implemented for Chrome
java/test/org/openqa/selenium/bidi/input/CombinedInputActionsTest.java
@NotYetImplemented(CHROME)
annotation to a test, marking it notyet implemented for Chrome.
DefaultMouseTest.java
Ignore Default Mouse Tests for Chrome on GitHub Actions
java/test/org/openqa/selenium/bidi/input/DefaultMouseTest.java
@Ignore(value = CHROME, gitHubActions = true)
to tests, ignoringthem for Chrome on GitHub Actions.
NetworkCommandsTest.java
Enable Network Commands Tests for Chrome
java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java
@NotYetImplemented(CHROME)
annotations.NetworkEventsTest.java
Enable Network Events Tests for Chrome
java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java
@NotYetImplemented(CHROME)
annotations.LocalValueTest.java
Enable Script Local Value Tests for Chrome
java/test/org/openqa/selenium/bidi/script/LocalValueTest.java
@NotYetImplemented(CHROME)
annotations.ScriptCommandsTest.java
Enable Script Commands Tests for Chrome
java/test/org/openqa/selenium/bidi/script/ScriptCommandsTest.java
@NotYetImplemented(CHROME)
annotations.ScriptEventsTest.java
Enable Script Events Tests for Chrome
java/test/org/openqa/selenium/bidi/script/ScriptEventsTest.java
@NotYetImplemented(CHROME)
annotations.StorageCommandsTest.java
Enable Storage Commands Tests for Chrome
java/test/org/openqa/selenium/bidi/storage/StorageCommandsTest.java
@NotYetImplemented(CHROME)
annotations.7 files
BUILD.bazel
Include Chrome in Bazel Large Tests Configuration
java/test/org/openqa/selenium/bidi/browser/BUILD.bazel
BUILD.bazel
Include Chrome in Bazel Browsing Context Tests Configuration
java/test/org/openqa/selenium/bidi/browsingcontext/BUILD.bazel
BUILD.bazel
Include Chrome in Bazel Input Tests Configuration
java/test/org/openqa/selenium/bidi/input/BUILD.bazel
BUILD.bazel
Include Chrome in Bazel Log Tests Configuration
java/test/org/openqa/selenium/bidi/log/BUILD.bazel
BUILD.bazel
Include Chrome in Bazel Script Tests Configuration
java/test/org/openqa/selenium/bidi/script/BUILD.bazel
BUILD.bazel
Include Chrome in Bazel Storage Tests Configuration
java/test/org/openqa/selenium/bidi/storage/BUILD.bazel
BUILD.bazel
Refactor RemoteWebDriverBiDiTest Bazel Configuration
java/test/org/openqa/selenium/grid/router/BUILD.bazel
configuration.